Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve-code-indentation #8 #20

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

improve-code-indentation #8 #20

wants to merge 1 commit into from

Conversation

pmichielsen
Copy link

pywkm
pywkm reviewed Oct 21, 2018
View reviewed changes
Copy link

@pywkm pywkm left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, to be honest I don't see you resolved any of indentation problems (complex if statements) stated in issue #8. You mostly changed variables names (which is good) but added some IMO ugly construction like \ at the end of lines

@pmichielsen
Copy link
Author

Correct, I didn't get round to the if statements themselves late Friday night but wanted to get the code clean-up out of the way first. The \ is just what I'm used to 🤓

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pywkm pywkm pywkm left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pmichielsen @pywkm